search

donaldzou / WGDashboard

Simple dashboard for WireGuard VPN written in Python & Vue.js
https://donaldzou.github.io/WGDashboard-Documentation/
Apache License 2.0
1.63k stars 252 forks source link

Big Docker Image update. #437

Closed DaanSelen closed 3 weeks ago

DaanSelen commented 1 month ago

Hi Donald, after working hard on this Docker image update:

Fixed Docker Readme for: https://github.com/donaldzou/WGDashboard/pull/430

Added new persistency through symlinks, which makes the biggest feature possible \/ Added Docker image update possibility. From for example 4.0.3 -> 4.0.4 (as long as Arch Linux is supported in wgd.sh.

Refactored lots of code.

donaldzou commented 1 month ago

Thank u for working on this! Just wondering, is ArchLinux the best option for the Docker base OS? Curious why not Ubuntu?

DaanSelen commented 1 month ago

Hi Donald, It's not Arch but Alpine. Ubuntu would also be possible but it comes packaged with more... everything, so it creates a bigger image,

donaldzou commented 1 month ago

Hi Donald, It's not Arch but Alpine. Ubuntu would also be possible but it comes packaged with more... everything, so it creates a bigger image,

Ahh gotcha, I guess Alpine is better then :)

DaanSelen commented 1 month ago

Saying better is always opinionated, but it is a general choice of many... many docker images! We could perhaps in the future look into the python image based on alpine as a base (if there is one). But the image itself is already (compressed) 33.48 MB, which is... in my opinion pretty small.

You can test the image yourself, if you'd like! It works much better now! Or pull it from dselen/wgdashboard:latest

donaldzou commented 1 month ago

Saying better is always opinionated, but it is a general choice of many... many docker images! We could perhaps in the future look into the python image based on alpine as a base (if there is one). But the image itself is already (compressed) 33.48 MB, which is... in my opinion pretty small.

You can test the image yourself, if you'd like! It works much better now! Or pull it from dselen/wgdashboard:latest

Gotcha gotcha, yeah I think a smaller image size would be better :)

DaanSelen commented 1 month ago

To clarify, only the db folder and the wg-dashboard.ini file are now persistent, all other things are ephemeral.

donaldzou commented 4 weeks ago

Hi @DaanSelen , are you still working on this PR?

DaanSelen commented 4 weeks ago

Hi @DaanSelen , are you still working on this PR?

For now I am done. Before I keep making changes. Next one will be the language.

DaanSelen commented 4 weeks ago

I can merge now, but before that I am going to do some more testing. So I don't break anything.

DaanSelen commented 3 weeks ago

It has succeeded my tests, what do you think Donald?

Thanks for the time!