donalgrant / spiro

Code and notebooks related to spirograph and harmonographs
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Fix connections in heart drawing #1

Closed donalgrant closed 1 year ago

donalgrant commented 1 year ago

The connections between the spiro_arc, roll, and rotation pieces don't work. Probably requires:

donalgrant commented 1 year ago

Start by fixing simpler connections:

  1. spiro_line works, so try a version of spiro_line which is other than horizontal: call it "spiro_angle" and give it a slope.
  2. connect across the ends of spiro_arc.
donalgrant commented 1 year ago

modified spiro_line to take an orientation -- this works and connects. (Should really include an origin location for that function...)

donalgrant commented 1 year ago

spiro_arc is now connected. Almost there with heart drawing: what's tricky is the start and end "guards" for the inside of angles which are drawn by arcs. Guards are working on inside of straight angles drawn by roll function.

donalgrant commented 1 year ago

fixed for poly_heart. Still need to get continuity across roll/arc join.

donalgrant commented 1 year ago

Required new routines to calculated guard for converging arcs, but mission accomplished!