donatj
commented
6 years ago Some of the regex stuff absolutely makes sense and should be merged.
However, running a benchmark script I wrote on my local copy of PHP 7.1 your version is consistently coming out just a little slower.
I'm honestly not sure what's causing the difference.
If you care to research my benchmark script is below.
It runs through all the user agents in my test suite 10,000 times - feel free to experiment with the script below yourself.
<?php
require 'Source/UserAgentParser.php';
$uas = json_decode(file_get_contents(__DIR__ . '/tests/user_agents.json'), true);
$time = microtime(true);
for($i = 0; $i <= 10000; $i++){
if($i % 1000 == 0) {
echo ($i / 1000) . ' ';
}
foreach($uas as $ua => $expected_result) {
$result = parse_user_agent($ua);
}
}
echo "\n";
echo microtime(true) - $time;
echo "\n";
frankmayer
Hi Jesse,
Just a small contribution. Some micro optimizations and stricter comparisons.
Thank you for your work. :+1: