search

donatj / PhpUserAgent

Lightning Fast, Minimalist PHP User Agent String Parser.
https://donatstudios.com/PHP-Parser-HTTP_USER_AGENT
MIT License
559 stars 129 forks source link

doubt about an if #49

Closed zephirfan closed 5 years ago

zephirfan commented 6 years ago

https://github.com/donatj/PhpUserAgent/blob/3b4a1e04bd27910d06ced0205ee0864b56aa8ae7/Source/UserAgentParser.php#L148

Is this !($key = 0) ok?

donatj commented 6 years ago

Hmm… It looks like I was doing some sort of gross hack back in the day to lower the LoC.

I'll need to poke this a bit but it appears the tests pass when I remove it.

donatj commented 5 years ago

This was removed a while ago.

Thank you for the heads up!

Closing.