search

donatj / mock-webserver

Simple mock web server in PHP for unit testing.
MIT License
131 stars 21 forks source link

Replaced STDIN constant with php://stdin #48

Closed tuutti closed 1 year ago

tuutti commented 1 year ago

The STDIN constant is defined by cli SAPI and it doesn't seem to be defined when running Drupal's functional tests:

image

I didn't dig too deep to figure out why, but I think it has something to do how Drupal sets up the functional/browser test stack:

https://www.drupal.org/docs/automated-testing/phpunit-in-drupal/phpunit-browser-test-tutorial#s-how-drupals-browser-tests-work

donatj commented 1 year ago

That might just be an issue with running it within PHPStorm.

Regardless, it’s a known issue and I should have caught it in code review. Thanks for the fix.

donatj commented 1 year ago

Your fix made it into this new release. Thank again!

https://github.com/donatj/mock-webserver/releases/tag/v2.6.1

tuutti commented 1 year ago

Thanks for fast fix!

donatj commented 1 year ago

At long last we added Windows support, which made for a huge release. I've got my ear to the ground for any unexpected issues!