donavanbecker / homebridge-rainbird

The Homebridge RainBird plugin allows you to access your RainBird Controller from HomeKit with Homebridge.
ISC License
20 stars 0 forks source link

Bug: Some errors are logged without timestamp and plugin name #520

Open mantorok1 opened 6 months ago

mantorok1 commented 6 months ago

Describe The Bug

Some errors are logged without timestamp and plugin name

To Reproduce

Turn off RainBird controller for a while so plugin cannot connect to it

Expected behavior

Error log messages should be prefixed with timestamp and plugin name

Relevant log output

Since version 2.0 of plugin error are logged like this:
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds
RainBird controller request failed. [Error: connect EHOSTUNREACH 192.168.1.105:80]
Failed Request: [18] [ControllerDateGetRequest]
Will retry in 60 seconds

Note that timestamp and plugin name are missing

Config for homebridge-rainbird

N/A

Screenshots

No response

Device & Model

TM2

Node.js Version

v18.18.2

NPM Version

v9.8.1

Homebridge Version

v1.7.0

Homebridge Rainbird Plugin Version

v2.0.0

Homebridge Config UI X Plugin Version

v4.55.1

Operating System

Docker

donavanbecker commented 3 months ago

@mantorok1 just released 2.0.3, which you implemented the event loggings, right? So we should be able to close this?

mantorok1 commented 3 months ago

I believe so. Does it work ok? I haven't had a chance to test it yet