dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Export to Excel isn't actually exporting an unweighted graph when selected #1018

Closed Onariaginosa closed 1 year ago

Onariaginosa commented 1 year ago

When exporting a workbook or demo that already has weight information in them, if you select unweighted in the first expression menu, the 2nd menu will include the network_optimized_weights and the network_weights sheets as sheet options. And if you export with those sheets and load the exported workbook it will load as a weighted graph (as it should).

To fix this consistency issue should any network weights sheets be excluded when an unweighted network is selected, or is selecting an unweighted vs weighted graph even necessary when you can select which network sheets to export. Another option is also to keep the buttons and use them to determine which network sheets are selected by default, (weighted will select all network sheets, unweighted will uncheck the network weights sheets)

Screenshot from 2023-02-01 06-00-56

Screenshot from 2023-02-01 06-01-05

kdahlquist commented 1 year ago

After discussion, we decided that the two modals can be collapsed into one.

Onariaginosa commented 1 year ago

Made the requested changes. image

kdahlquist commented 1 year ago

Confirmed in v6.0.7