search

dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Change names for environment variables pertaining to the database #1030

Open Onariaginosa opened 1 year ago

Onariaginosa commented 1 year ago

We should rename the server environment variables EXPRESSION_DB_USERNAME and EXPRESSION_DB_PASSWORD to something more generic like DB_USERNAME and DB_PASSWORD because our database contains more than just expression data now.

kdahlquist commented 2 weeks ago

Elevating the priority of this issue to see if it is an "easy" fix.

ntran18 commented 1 day ago

The variables are saved in .env file but I don't know where the file is.

dondi commented 1 day ago

Ah yes that’s true—the .env file is actually not meant to be committed in case it contains secrets. (notice that it is in .gitignore)

I can look for mine and can send you a copy by other means

ntran18 commented 1 day ago

Yes! I don't expect I have access to that file 😅. Can you just help me to fix the variable names? And I can fix it in code.

EXPRESSION_DB_USERNAME -> DB_USERNAME EXPRESSION_DB_PASSWORD -> DB_PASSWORD

We can confirm if this is a good name to change, then I will make a PR with the name change. When @dondi merge, @dondi can change the variable names in .env file

dondi commented 1 day ago

Sounds like a plan! 👌🏽