dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Can only change dataset from bottom option, not top #1033

Closed Sarronnn closed 9 months ago

Sarronnn commented 1 year ago
Screenshot 2023-04-11 at 11 38 28 PM Screenshot 2023-04-11 at 11 39 24 PM
kdahlquist commented 9 months ago

This still has some problems on Beta 7.0.2

dondi commented 9 months ago

Fundamentally, the core issue is that the selected dataset should be centralized to an internal state value: whenever any control or UI element changes this value, that change should lead to the same code regardless of the source. Doing so will ensure that the internal behavior is always the same independent of whether the change was made on the sidebar or the menu

dondi commented 9 months ago

@ntran18 as a PR for this and that is what the “review requested” tag indicates; however she documents that a subsequent bug appears which seems to be more related to the dataset than the UI

@ntran18 will extract this as a separate issue, likely to be addressed after this one is merged into beta

dondi commented 9 months ago

The UI-level bug appears to be fixed but the fix is disrupted by a new issue that appears to occur at the data level, especially for expression data sets that come from the database and are not read from the network directly. Will consider this item as closed but @ntran18 will write up and investigate the missing data portion as a new issue

The new issue can reference this one in case we need to review how it was discovered