dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Restrict Graph to Viewport Bug #1034

Closed Sarronnn closed 9 months ago

Sarronnn commented 1 year ago
Screenshot 2023-04-11 at 11 42 46 PM
Sarronnn commented 1 year ago
Screenshot 2023-04-11 at 11 49 32 PM

=> Same error as #945 ; looks like the root cause is the specific dependency versions that are installed when running a version of Node that is too old. But I want to double check with Dondi

dondi commented 10 months ago

Needs a reproduction check

dondi commented 10 months ago

Reproduction confirmed during meeting; @nchun2 will isolate the bug further and will post a comment detailing how it can be reproduced:

nchun2 commented 10 months ago

The bug also occurs in beta when the "restrict graph to viewport" function is selected from the top menu, but not from the side menu. Occurs in both production and beta when the network is loaded from a database on either the top menu or the side menu. It seems that the bug occurs whenever the view function is selected from the top menu.

dondi commented 10 months ago

Great! I’m adding @ntran18 to this bug but will keep @nchun2 for now in case some clarification is needed for reproducing the bug

ntran18 commented 10 months ago

The main problem with this is originally Restrict Graph to Viewport in the top menu has a class called "viewportOption", and whenever this class is change, it will update grnState.viewportSize. However, Restrict Graph to Viewport is not a viewport size, so there is no constant for that, and when passed to grnState.viewportSize, it is a null value, and the graph keeps changing the size.

kdahlquist commented 9 months ago

Confirmed that this is fixed in beta 7.0.2 on Firefox