Closed ntran18 closed 4 months ago
I retried this using some chosen proteins instead of one of the demos, and the name of cell A1 was still an issue.
@nchun2’s report was done from beta
but at the time, beta
did not have the PR yet; will need to revisit after merging
In order to try something out before it is merged to beta
, one can switch to the git branch that contains the fix(es) locally. Then the local version of the app can be tested. For example, specifically with this issue, the command would be:
git switch maika-1054-new
Once finished, switch
can be invoked again to go back to whichever original branch you were on, e.g.:
git switch beta
After noting the test suite failures and reviewing the PR, we noted that the change in heading should not be wholesale but instead conditional on the type of network being exported. For GRNs, we keep the existing heading; the change in heading should only be done for protein-protein networks
Extending the test suite to include protein-protein-specific test files would also be desirable but their absence doesn’t break the build, only limiting the test coverage. It will be separated out into its own issue due to the scale involved with recreating the test suite completely
I haven't had time this week to do this issue, due to busy week. I will try to do this issue this week
See #1070 for a deeper treatment on this particular issue
We had some general discussion about the differences between a GRN and PPI network.
I made a commit for this issue. The server is the one doing the export. Therefore, I change the code in the server folder. However, I wasn't able to change the test. I need to talk with Dr. Dondi for help. I also linked the commit below.
f19f1dc3e0b5e8868764698a56f01623e54789c9
Since the code was merged and no problem was found currently, Is it reasonable to close this issue? @dondi @kdahlquist
I have verified that a change was made to cell A1 of the network sheet when exporting a PPI network. However, the exact text to appear in cell A1 (as requested in the first comment) should be "Cols protein1, rows protein2". @ntran18, will you please make this change?
This issue is fixed.
Confirmed fixed in beta 7.0.13
Problem: Cell A1 of the exported Excel workbook "network" sheet does not need to say "Cols regulators, rows targets", instead it should say "Cols protein1, rows protein2"
Example from demo 1:
--> Cell A1 stills have the name Cols regulators, row targets