node coloring glitch when loading network from database

dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.

http://dondi.github.io/GRNsight

BSD 3-Clause "New" or "Revised" License

17 stars 8 forks source link

node coloring glitch when loading network from database #1080

Open kdahlquist opened 5 months ago

kdahlquist commented 5 months ago

Do this in beta 7.0.8:

load a GRN from the database
uncheck node coloring
recheck nod coloring--the checkbox gets checked and the node coloring comes back in the display, but the options don't show on the side panel

This bug is also seen in production 6.0.7

ceciliazaragoza commented 3 months ago

I tried this on beta 7.0.13 and this behavior no longer seems to be occurring. However, I do see that this is an issue when checking and unchecking node coloring for PPIs. @kdahlquist Should I disable the ability to check or uncheck node coloring for PPIs?

kdahlquist commented 3 months ago

I think we should keep the ability to check/uncheck node coloring for PPIs. People might have protein-expression data that they want to visualize or they might want to overlay the mRNA expression data on the PPI network.

ceciliazaragoza commented 3 months ago

I mentioned that the workbook was the issue during the meeting, but after looking over the code again, that was not the issue. There was a check for grnState.mode === NETWORK_PPI_MODE where grnState.nodeColoring.nodeColoringEnabled was set to false. I was able to get the Node Coloring Menu to show with PPIs, but should the options below "Enable Node Coloring" still display when viewing a PPI?

kdahlquist commented 3 months ago

Yes, those options should show because they enable the user to customize how the nodes are colored.

dondi commented 2 months ago

We clarified at the 4/23 meeting that we can go ahead and have the warning appear each time. A “don’t show this again” option might be something for the future