search

dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

D-pad, zoom slider, and cursor drag do not move graph after export to SVG #1093

Open ceciliazaragoza opened 4 months ago

ceciliazaragoza commented 4 months ago

After exporting a graph to SVG, the D-pad can be clicked and the zoom slider can be moved. However, the cursor hand does not close, and the graph does not move and remains at the same zoom and position as when exported. However, if you reload the graph, choose a demo, or open a file, the cursor grab and zoom slider move the graph again. This issue is in the master branch as well.

dondi commented 4 months ago

Suspicion here is that the export routine manipulates the SVG elements in-place to make them export ready but those changes then impact the web app. Ideally the SVG export operates on a deep copy of the SVG tree so that it doesn’t leave any unintended side effects

ceciliazaragoza commented 3 months ago

This seems to be the same issue as in #1059 because the SVG is modifying the graph itself.

dondi commented 3 months ago

To elaborate further, #1059 may be the root cause of this bug; that is currently assigned to @ntran18. @ceciliazaragoza will monitor both issues and update accordingly if it does turn out that they are bound together