dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Assorted cosmetic changes #38

Closed dondi closed 10 years ago

dondi commented 10 years ago

Some items that were not already transcribed from Thursday’s whiteboard notes:

britainjs commented 10 years ago

I implemented the 1st two of the list.

dondi commented 10 years ago

For the first bullet, we will go with custom markers for each thickness because the automatic way blows them up too much.

dondi commented 10 years ago

So as not to have too many custom markers, explore whether a transform can be applied.

britainjs commented 10 years ago

Adjusting the radius of the self-referencing edges and adding an offset to compensate for the larger sizes inadvertently solved the orientation issue, so the self-referencing arrowheads look pretty good now.

kdahlquist commented 10 years ago

The demo is not working for me so I can't see the changes. I used this file: dahlquist_wt-data_21-gene- sample-output_20140122_est_out_1.xlsx

At 04:07 AM 4/20/2014, you wrote:

Adjusting the radius of the self-referencing edges and adding an offset to compensate for the larger sizes inadvertently solved the orientation issue, so the self-referencing arrowheads look pretty good now.

— Reply to this email directly or https://github.com/dondi/GRNsight/issues/38#issuecomment-40892650view it on GitHub.

britainjs commented 10 years ago

I was waiting until I had the flat arrowheads done to update the demo page so we didn't have a half-finished patch on public display, but those are done now and the server is updated. I checked with the output file and it was working like intended. The sizes for all the arrowheads are manual now, so getting the right size and offset is just going to be a matter of adjusting numbers. I experimented quite a bit before I found the current settings, which I tried to make a balance between having a noticeable difference between node sizes and still looking acceptable. Sizes larger than where they are tended to make the markers and edges overlap too much and smaller arrowheads would get eclipsed by the edges they were attached to. Let me know how this looks and I can do more adjustments.

dondi commented 10 years ago

State of prior refinements, all done:

New cosmetic refinements:

britainjs commented 10 years ago
dondi commented 10 years ago
britainjs commented 10 years ago
kdahlquist commented 10 years ago

I can't connect to the server to see these:

Firefox can't establish a connection to the server at grnsight.cs.lmu.edu:3001.

At 03:13 AM 5/5/2014, you wrote:

  • Reduced self-referential radius by another 15%.
  • Highlight color changed to orange and highlights added to incoming edges as well.
  • Vertical centering restored.

— Reply to this email directly or https://github.com/dondi/GRNsight/issues/38#issuecomment-42174619view it on GitHub.

dondi commented 10 years ago

I visited grnsight.cs.lmu.edu and Britain took ownership of the server processes—Britain, you only have one node process running. You need two, one for the web service and the other for the web client. I think that is the issue.

britainjs commented 10 years ago

Weird, I could have sworn I tested both of them before logging out of the server. I'll get it up right now.

-----Original Message----- From: dondi notifications@github.com To: dondi/GRNsight GRNsight@noreply.github.com Cc: britainjs bsouthwi@lion.lmu.edu Sent: Mon, May 5, 2014 12:14 pm Subject: Re: [GRNsight] Assorted cosmetic changes (#38)

I visited grnsight.cs.lmu.edu and Britain took ownership of the server processes—Britain, you only have one node process running. You need two, one for the web service and the other for the web client. I think that is the issue. — Reply to this email directly or view it on GitHub.

britainjs commented 10 years ago

Its up. I think I left the ssh connection open on my computer without detaching the screen, so it complained when my computer went to sleep.

kdahlquist commented 10 years ago

Closing issue and opening separate issues for things unresolved.