Closed kdahlquist closed 7 years ago
When discussing #396, #397, and #399, @NAnguiano and @kdahlquist discussed the following changes to the UI that should be implemented right away:
I looked at the beta in its current state as of Saturday April 1 (which according to another issue is consistent with version 2.0.3) alongside the comment above, and have the following thoughts:
Those are my "big picture" thoughts on seeing the beta scrolling and zooming functionality/user interface in its current state. I will scan the other issues to see if more focused thoughts come to mind.
To respond to @dondi's comments:
I think everything here is done as well and in PR #459. I am particularly enjoying the Fixed to Window option. Enough that I think it may be worth it to have that as the default option rather than the sizes.
I'm looking at beta v2.0.14. Just a small issue in the labels:
Instead of (1104x648px), it should say (1104 X 648 pixels) and etc. for the others.
I think there's room for that.
Like this? @kdahlquist
Yes, exactly. Also, while you're at it, can you tighten up the vertical spacing? Right now when I'm using my laptop and got the menu bar flush with the top of my browser screen, the options for Normalization are off the bottom of my screen. If we tighten the vertical space, there's a chance it will all fit on one screen's worth of real estate.
Found and fixed a bug where whenever the window was resized it would switch it to Fit to Window.. oops! As for that vertical spacing, @kdahlquist what do you think of this?
Here it is in reference with the UI, on my 13" laptop.
Sure, looks good. Won't be able to give a final comment until I can see it "live". By the way, @anuvarsh, I'm pretty sure we don't need the "minimum" field for the normalization factor anymore. I don't know if it will mess up anything that she'd doing if @NAnguiano takes it out.
I've made some changes to the structure of the sidebar in the code, so it may cause some merge conflicts regardless. I can remove it now, but it will ultimately be removed when @anuvarsh merges her fork in. I've made a PR with the visual changes as well as that bug fix.
The minimum box isn't there anymore in my branch. The newest version of normalization has not been merged to beta yet because of all of the bugs. Once I issue a pull request the extra box will be gone.
All open tasks from this issue have been moved to new issues #462, #463, #464. So, I'm closing this one.
@dondi, @NAnguiano, and @kdahlquist had a meeting on 2/27 to discuss changes to the GRNsight UI needed to support the new features of drafting board and viewport resizing, showing/hiding weights, changing weight normalization value, and eventually graph statistics.
We didn't have as much time to meet as we would have liked, but here is a summary of what we talked about: