Consolidate existing web app API calls into an abstraction layer

dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.

http://dondi.github.io/GRNsight

BSD 3-Clause "New" or "Revised" License

17 stars 8 forks source link

Consolidate existing web app API calls into an abstraction layer #957

Closed dondi closed 1 year ago

dondi commented 2 years ago

@Onariaginosa started some work in #950 which, although is different from a DAL, works on the same principle of consolidating implementation code behind functions so that other code does not have to factor in those implementation details. On the web client side, this involves all networking code. Ideally, network code is restricted to a single module which declares functions that deliver the results of that code, and the rest of the web app only “sees” these as functions

dondi commented 1 year ago

Upon revisiting this issue, it appears that it has already been done. @Onariaginosa, @ahmad00m, and @Sarronnn can walk through this code together to verify that the transition has indeed been completed:

Ensure that all back end interactions go through the public/js/api/grnsight-api.js functions only
Look for vestigial calls to $.ajax or $.getJSON, maybe even window.fetch and refactor those to use functions from grnsight-api.js instead

If the transition looks complete, we can go ahead and close this issue

dondi commented 1 year ago

Code has been reviewed and one last spot check during 10-12 meeting supports this

There are lingering $.ajax and $.getJSON calls in the code, but these are for server functions that do not access the database. Technically good to also transition but these were not in the scope of this issue