Closed dondi closed 1 year ago
Upon revisiting this issue, it appears that it has already been done. @Onariaginosa, @ahmad00m, and @Sarronnn can walk through this code together to verify that the transition has indeed been completed:
$.ajax
or $.getJSON
, maybe even window.fetch
and refactor those to use functions from grnsight-api.js insteadIf the transition looks complete, we can go ahead and close this issue
Code has been reviewed and one last spot check during 10-12 meeting supports this
There are lingering $.ajax
and $.getJSON
calls in the code, but these are for server functions that do not access the database. Technically good to also transition but these were not in the scope of this issue
@Onariaginosa started some work in #950 which, although is different from a DAL, works on the same principle of consolidating implementation code behind functions so that other code does not have to factor in those implementation details. On the web client side, this involves all networking code. Ideally, network code is restricted to a single module which declares functions that deliver the results of that code, and the rest of the web app only “sees” these as functions