search

dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

Clarifying Load from Database modal #982

Closed kdahlquist closed 1 year ago

kdahlquist commented 2 years ago

Load-from-Database-modal_v6 0 0

kdahlquist commented 2 years ago

Here are my comments on the Load from Database modal.

  1. I'm wondering whether it should say "Generate Network". "Create" implies to me that the user might get to choose the edges when they are only choosing the genes.
  2. For Network Source, the name needs to fit so that the entire thing can be read. I suggest to simply call it "YeastMine - ", like "YeastMine - 2022-09-07" for regulation data that was downloaded today. So go back to see what date you downloaded the data and use that. The dropdown is intended so that users can select between different versions of the data. We might in the future also consider pulling data from a particular paper (like we do for the expression data).
  3. I need some more explanation to understand the warning. Do you mean that if someone chooses something different from the dropdown, it will erase the selected genes below? Or do you mean that by using this Generate Network, their previously loaded network will go away? or both? After I know what this is about, I can suggest some clarifying language.
  4. The Network Source and Select Genes text needs to be aligned, as do the boxes next to them. The gene select box needs to be resized slightly to match the search button.
  5. The "Generate Network" button needs to be relocated next to the "close" button.
  6. Rename "close" to "cancel"
  7. "Click on the gene to remove it." needs a period.
Onariaginosa commented 1 year ago
  1. I will make that change, and shorten the source name. Should I shorten the source name within the database, or create logic to display a limited amount of characters of the source and the timestamp.
  2. The warning is if someone chooses something different from the dropdown, it will erase the genes they have searched for already. I wasn't intending to warn that their previously loaded network will go away, because that seemed kinda self explanatory (the network is the first step in the user pipeline, but maybe that isn't clear)

I will change the other comments as requested, and send screenshots for confirmation

Onariaginosa commented 1 year ago

I implemented changes 1, 4, 5, 6, and 7. Waiting for feedback before I implement changes 2 and 3. Screenshot from 2022-11-09 10-10-13

dondi commented 1 year ago

We can do this in the database but we should define a new display_name column that we will switch to when displaying a source to the user. This will avoid cascading changes due to reference key constraints and will allow more freedom in customizing how we list a source

Onariaginosa commented 1 year ago

Implemented 2 and 3 as requested. Screenshot from 2022-11-16 09-54-38 I made this change (adding a display_name column) in the databases, and altered the schema, generator, and loading files to do so.

kdahlquist commented 1 year ago

Confirmed as complete