dondi / GRNsight

Web app and service for modeling and visualizing gene regulatory networks.
http://dondi.github.io/GRNsight
BSD 3-Clause "New" or "Revised" License
17 stars 8 forks source link

yeast genes that have naming patterns not allowed by load network from database function #989

Closed kdahlquist closed 1 year ago

kdahlquist commented 1 year ago

I've been playing around with the load network from database function to see what happens when I try to find yeast genes that have unconventional naming patterns.

kdahlquist commented 1 year ago

Just for posterity, here are the genes I tested. oddball-yeast-genes

kdahlquist commented 1 year ago
dondi commented 1 year ago
  1. Scan gene expression and regulation database
  2. Look for IDs with commas, apostrophes, and parentheses—replace with new ones for the above four genes
  3. For genes with parentheses, note what appears and pass along to #997 for regex adjustment

After this is done, #997 can then follow

Domain note: We anticipate that these are legacy fixes and future genes, if any, will be made to comply with the stricter naming conventions. Thus, a general solution appears to be unnecessary

Onariaginosa commented 1 year ago

I scanned the database and found that the only genes in our database with unusual names are the following: Screenshot from 2022-11-09 11-10-41

Because of this I just created an exceptions object that maps the irregular name to a name that we accept within GRNsight: Screenshot from 2022-11-09 11-12-37

This issues should be resolved in PR #996, as I was working on fixes for that simultaneously.

kdahlquist commented 1 year ago

confirmed fixed in beta 6.0.7