Closed kdahlquist closed 1 year ago
Just for posterity, here are the genes I tested.
After this is done, #997 can then follow
Domain note: We anticipate that these are legacy fixes and future genes, if any, will be made to comply with the stricter naming conventions. Thus, a general solution appears to be unnecessary
I scanned the database and found that the only genes in our database with unusual names are the following:
Because of this I just created an exceptions object that maps the irregular name to a name that we accept within GRNsight:
This issues should be resolved in PR #996, as I was working on fixes for that simultaneously.
confirmed fixed in beta 6.0.7
I've been playing around with the load network from database function to see what happens when I try to find yeast genes that have unconventional naming patterns.
MF(ALPHA)1
andMF(ALPHA)2
. If I search for either of those with their parentheses, they trigger the error modal. They are in the database, though, because if I search on them based on their systematic names, YPL187W and YGL089C, they come up properly. I think we are going to need to allow parentheses in the input to that search field so that they will be properly retrieved.