search

donejs / bitballs

A basketball tourney application.
https://donejs.com/bitballs.html
MIT License
11 stars 17 forks source link

Fix bug causing jQuery undefined error #309

Closed imaustink closed 6 years ago

imaustink commented 6 years ago

Closed #308

imaustink commented 6 years ago

@matthewp although this PR fixes the issue, I feel like this fix is just a band-aid for an underlying issue in can-zone. When bootstrap/js/dropdown is loaded, jQeury is undefined but window.jQuery is jQuery as you would expect. Any thoughts?

chasenlehara commented 6 years ago

@imaustink You were right not to merge this; this was a real issue and fixed here: https://github.com/donejs/done-ssr/releases/tag/v1.3.1