NHT: Link to an individual stat

[josh-bitovi]

Rationale

For highlights (in emails), as well as future features (e.g. allowing admins to approve user-suggested stats), as well as encouraging users to share and create their own stats... we'd like to be able to link to a specific stat.

Implementation/design questions

@justinbmeyer do these requirements sound okay to you?

• Linking to a stat will seek the video to the right spot
• Video will loop for easy rewatching
• Video will not autoplay

Relevant YouTube API docs

YouTube supports start, end, and loop parameters.

[tehfedaykin]

Duplicate of #333

[josh-bitovi]

I can't self-assign, but I'll work on this one.

[josh-bitovi]

branch: 341/deep-link-stat commit: https://github.com/donejs/bitballs/commit/0fbb341f98979a2567b368f203e8b93fd80c1be5

Potential can-route-pushstate bug

Context

1. Made a route for /games/{gameId}/{statId}
2. Route appears to work (in that I get the statId passed in), but immediately redirects to /games/{gameId} (route order does not matter).

Steps taken to debug so far

1. Tried logging the changes, that shows:

1. Cleared and reinstalled node_modules/ (in both the project root and public/)
2. Restarted donejs develop
3. Added in logStack (on statId changes) and can.queues.log('flush') (in general). The logStack call shows:

Next steps

@justinbmeyer mentions parentTask: null should not be the case for changes managed by CanJS (though may be the case if you change things out-of-band). More investigation is needed. @justinbmeyer can you help w/this? I'll either pair w/you or pick up the next task.

CanJS DevTools

Was trying to use it to debug the above issue. It was detecting CanJS on the page (button in the upper-right), but not showing any components in the DevTools. I cannot reproduce this issue this morning.

[josh-bitovi]

Update:

• The issue was fixed by changing statId: value.to(this, "statId"), to statId: value.bind(this, "statId"), (issue: binding the value in the URL to the undefined value in the game details VM... rather than going from the URL to the VM, or two-way binding)
• The debugging curiosity was caused by new Component not registering as something that changes values (and as such not showing up in the logStack trace @justinbmeyer is making an issue for this.

Thanks @justinbmeyer for your help in debugging!