donejs / bitcentive

https://bitcentive.herokuapp.com/
MIT License
7 stars 3 forks source link

Logout button triggers lots of recomputes #340

Open m-mujica opened 7 years ago

m-mujica commented 7 years ago

When logout is clicked, there is a compute that cycles a lot times (happens in dev, and with optimized build).

If you have the dev-tools open you can see it hitting the else in the code below a bunch of times:

// can-connect-feathers/session/session
getData: function() {
    return new Promise(function(resolve, reject) {
      var tokenLocation = options.tokenKey || options.cookie;
      if (hasValidToken(tokenLocation) && !window.doneSsr) {
        feathersClient
          .authenticate()
          .then(function(data) {
            var payload = decode(data.accessToken);
            return resolve(payload);
          })
          .catch(reject);
      } else {
        reject(new errors.NotAuthenticated("Not Authenticated"));
      }
    });
  }

I added a console.log before the rejection and:

screen shot 2017-10-05 at 11 36 57