donejs / cli

The DoneJS command line interface
https://www.npmjs.com/package/donejs-cli
MIT License
6 stars 7 forks source link

Refactor donejs cli to improve testing and coverage. #52

Closed m-mujica closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.3%) to 91.597% when pulling d3a70ba30f548f0f99305985ee5c70a7be0271ac on code-coverage into 2d49dacc89bbf0d703873e6596f2c1f97449c590 on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.3%) to 91.597% when pulling d8185fd13ad68a8ea0581d47761731981329da22 on code-coverage into 2d49dacc89bbf0d703873e6596f2c1f97449c590 on master.

m-mujica commented 8 years ago

@matthewp there is a bug in node < 0.12.2 regarding windows and stdio that prevents the cli help output correctly, there is a test I wrote that makes sure the cli help is shown when no command is provided, that test is failing only in node@0.10 - windows (see https://github.com/tj/commander.js/issues/333, https://github.com/nodejs/node-v0.x-archive/issues/3584, https://ci.appveyor.com/project/matthewp/cli/build/1.0.283/job/3ed4y5s6gmj5p0sy)

It's kind of a silly test, but I noticed that donejs/donejs is not tested against 0.10 (which is fairly old), we can either skip the test, or remove node@0.10 from the donejs-cli environments.

What do you think?

matthewp commented 8 years ago

Let's skip it, want to leave in the rest of 0.10 testing.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.3%) to 91.597% when pulling 12de4c9486442258414629e3b45cc0764cd9fc26 on code-coverage into 2d49dacc89bbf0d703873e6596f2c1f97449c590 on master.