donejs / cli

The DoneJS command line interface
https://www.npmjs.com/package/donejs-cli
MIT License
6 stars 7 forks source link

The CLI should warn if passed invalid arguments #96

Open matthewp opened 6 years ago

matthewp commented 6 years ago

@imaustink commented on Mon Sep 18 2017

How often can you reproduce it?

Description: Running invalid commands exits without any warning. In my opion, this should at least output help.

Steps to reproduce: Run donejs app add some-app.

donejs-cli-no-error

Expected results: The CLI logs a warning or help.

Actual results: The CLI exits silently.

Environment:

Software Version
donejs -V 1.0.1
node -v 8.4.0
npm -v 5.3.0
Operating system Mac OS 10.12.6

@matthewp commented on Thu Jan 18 2018

Hey @imaustink, sorry for taking so long to reply. So, what donejs actually does it defer to donejs-cli. donejs-cli will look in node_modules/.bin/ and then package.json's .scripts, for, in this case app. So the fact that it doesn't warn when it finds something is something we can (hopefully) fix in donejs-cli. Going to move this issue there.