search

donejs / deploy

Deployment utilities for DoneJS
MIT License
4 stars 1 forks source link

Adding firebase service to donejs deploy #37

Closed mjstahl closed 9 years ago

mjstahl commented 9 years ago

Remove divshot packages

Update readme

Fixed some errors where the configuration was not available in package.json

Authentication for firebase

Remove test config from package.json

Finished deployment from package.json

Reading config from firebase.json

mjstahl commented 9 years ago

I still need to add tests.

matthewp commented 9 years ago

We don't actually want to remove Divshot yet, it's still working and depend on it for DoneJS chat and place-my-order (for now). Others might be using it as well so I think we should leave it in until it shuts down. However if you want to put a warning on the cli or something that would be ok.

daffl commented 9 years ago

We also might want to refactor this to work like donejs add cordova (e.g. donejs add deploy firebase). I don't think it would be too difficult but remove the hard dependency on DoneJS deploy.

matthewp commented 9 years ago

@daffl great idea, i've opened a new issue for that https://github.com/donejs/deploy/issues/38 and will do that next. I'm going to finish the test for this one first.