search

donejs / done-component

A plugin for creating <can-component>s
https://www.npmjs.com/package/done-component
MIT License
8 stars 2 forks source link

.component files should include the filename when rendering their view #99

Closed mjstahl closed 5 years ago

mjstahl commented 5 years ago

https://github.com/donejs/done-component/blob/52217ff50f5e0fc7a3140f7907322f96bdaa14a1/component.js#L253

The call to stache is missing the 0th argument (the filename).

It might be possible to approach this how steal-stache does:

https://github.com/canjs/steal-stache/blob/b45140da0b1ce7cdeb27f45bfb4796863187672a/steal-stache.js#L41

And the associated test:

https://github.com/canjs/steal-stache/pull/46/files