donejs / done-serve

DoneJS development server
https://www.npmjs.com/package/done-serve
MIT License
7 stars 5 forks source link

An in-range update of done-ssr is breaking the build 🚨 #166

Open greenkeeper[bot] opened 4 years ago

greenkeeper[bot] commented 4 years ago

The dependency done-ssr was updated from 3.2.11 to 3.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

done-ssr is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push:** The Travis CI build failed ([Details](https://travis-ci.org/donejs/done-serve/builds/604631434?utm_source=github_status&utm_medium=notification)).

Release Notes for Adds the xhrCache option

This adds xhrCache: false as an option.

Specifies if the XHR cache should be inlined into the page. The XHR cache is used to prevent duplicate requests from occuring in the client when hydrating from server-rendering HTML. In some cases you might not use XHR in the client and therefore want to prevent the script from being included.

const ssr = require('done-ssr');

const render = ssr({}, {
  xhrCache: false
});
Commits

The new version differs by 8 commits.

  • 1e06c8a 3.3.0
  • 32a1a02 Merge pull request #692 from donejs/xhr-option
  • cde8e8c Adds the xhrCache option
  • 0bfcdc2 Merge pull request #681 from donejs/xenial-migration
  • 589010e Don't bump dependecies
  • 8f0df61 Upgrading dependcies
  • f1e5145 Fix gcc installation for travis
  • 90881ac Migrate to use Xenial in Travis

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 3.2.11 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.