dcparser: Cannot import py modules named after reserved identifiers

donet-server / donet

Read-only mirror of https://gitlab.com/donet-server/donet

https://www.donet-server.org

GNU Affero General Public License v3.0

8 stars 2 forks source link

dcparser: Cannot import py modules named after reserved identifiers #16

Closed maxrdz closed 11 months ago

maxrdz commented 1 year ago

An example of a DC file line that will reproduce this 'bug':

from otp.char import DistributedChar

Tokens:

From Identifier Period **CharType** Import Identifier

Even though (to specification) this is correct behavior, as char is a reserved identifier, it is legal in python so we should make it legal to import in DC files as well.

maxrdz commented 11 months ago

Resolved, thank you @ooowoothevirtualhowler for bringing this to my attention over toontown :P