Submitting Prework: Tips Calculator Application

dongtanhuy commented 8 years ago

Here is my completed prework! Thank you /cc @coderschoolreview

coderschoolreview commented 8 years ago

:bow: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

coderschoolreview commented 8 years ago

:+1: Great job with the Tip Calculator!

I like the app background with the option to change it :smile:
It seems like the default percentage in Setting was not implemented. This is required. Pls update your code asap.
Good usage of NSUserDefaults. This is one of the methods to pass the data from multiple viewController. We will learn few more ways to do that.
If you were able to save the tipPercentage, why didn't you save the billAmount? (one of the optional). It should be exactly the same.
It's OK to use String(format: "$%.2f", tip) in this case, but if you change the language to Vietnamese for example, we don't use 2 digits after decimal point and the $ sign, right? I recommend to try NSNumberFormatter and CurrencyStyle
You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros, and the dots. I can also paste some text in the text field.

Your app is not able to remember the bill amount across app restarts. Whenever I restart, it shows 0 again.
I don't see the keyboard show up when the add first launch. You can show the keyboard immediately when app starts by using becomeFirstResponder

Bottom line, you need to complete the requirement for the default percentage in setting page. Others are optional.

coderschoolreview commented 8 years ago

Hi @dongtanhuy , any update on the default percentage in setting page.?

dongtanhuy commented 8 years ago

Sorry, I am busy now. I will update my code as soon as posible before 28th Feb

dongtanhuy commented 8 years ago

Hi, @coderschoolreview, I have just submitted my code to update on the default percentage in setting page! Thanks!

dongtanhuy / Prework-Tips-Application