dongweiming / lyanna

My Blog Using Sanic
http://www.dongwm.com
GNU General Public License v3.0
637 stars 173 forks source link

Undefined names: 'user' and 'cfg' #4

Closed cclauss closed 5 years ago

cclauss commented 5 years ago

flake8 testing of https://github.com/dongweiming/lyanna on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./views/j.py:61:57: F821 undefined name 'user'
    liked_comment_ids = await post.comment_ids_liked_by(user['gid'])
                                                        ^
./views/index.py:91:25: F821 undefined name 'cfg'
        return redirect(cfg.oauth_redirect_path)
                        ^
2     F821 undefined name 'cfg'
2

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

dongweiming commented 5 years ago

@cclauss Thank you for your comments, i have fixed it