search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

Bug: Activities or resources without a backup and restore implementation cause error in sharing cart #12

Closed Kathrin84 closed 4 years ago

Kathrin84 commented 5 years ago

Hi Don,

while testing your plugin for the latest Moodle 3.6 version we stumbled over this problem.

Problem By trying to move an activity or resource to the sharing cart which does not has implemented the backup and restore mechanism, sharing cart errors. The error message looks like this: operation_error This is just an excerpt. The content of the error message is a whole HTML file that says Exception - Class 'backup_[activityname]_activity_task' not found

Steps to reproduce

  1. Install a plugin that does not contain the backup and restore functionality. Currently, we could trigger this with mod_groupmembers (https://moodle.org/plugins/mod_groupmembers)
  2. Go to a course and add the resource "groupmembers" to your course
  3. Add this to the sharing cart
  4. Verify that you see the error message
  5. Verify that the resource is not added to the sharing cart

Proposal

Thanks and best, Kathrin

donhinkelman commented 5 years ago

Hi Kathrin, thanks for explaining this problem and making a clear proposal. Very human readable! And important to implement as there are several non-backup/restore plugins out there. I am sorry we are so slow to respond but our programmer is so busy doing his studies.