search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

Exposed stacktraces #167

Closed golenkovm closed 8 months ago

golenkovm commented 1 year ago

The plugin seems to expose stacktraces if it throws an exception https://github.com/donhinkelman/moodle-block_sharing_cart/blob/63bc1242cc6034749d0529ce20866c2f66daef14/rest.php#L107-L121

frederikmillingpytlick commented 8 months ago

It is default Moodle behaviour to print exceptions and stacktraces when debugging is enabled.

Closing issue

golenkovm commented 8 months ago

I'm actually confused (by myself). Can't remember what was the actual issue with this. There probably was something. I should provide more details when I was raising the issue (screenshots, use cases etc). Happy with the issue being closed until it shows back on my (or someone's else) radar and I/we have more details on this.

Cheers, Misha