search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

4.4 string error #198

Closed aspark21 closed 2 months ago

aspark21 commented 5 months ago

I know you''re working on a rewrite for Moodle 4.4. but just giving you a heads up of this error that came up during upgrade & when navigating the upgraded site.

Turnitin's string does exist - https://github.com/ucl-isd/moodle-mod_turnitintooltwo/blob/UCL_2023120501/lang/en/turnitintooltwo.php#L71 so assuming it's to do with something odd in sharing_cart.

Invalid get_string() identifier: 'modulename' or component 'turnitintooltwo'. Perhaps you are missing $string['modulename'] = ''; in mod/turnitintooltwo/lang/en/turnitintooltwo.php?
line 356 of /lib/classes/string_manager_standard.php: call to debugging()
line 7012 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 137 of /blocks/sharing_cart/lib/settingslib.php: call to get_string()
line 60 of /blocks/sharing_cart/settings.php: call to admin_setting_configmulticheckboxmodtypes->__construct()
line 128 of /lib/classes/plugininfo/block.php: call to include()
line 81 of /admin/settings/plugins.php: call to core\plugininfo\block->load_settings()
line 8857 of /lib/adminlib.php: call to require()
line 22 of /admin/upgradesettings.php: call to admin_get_root()
Invalid get_string() identifier: 'modulename' or component 'turnitintooltwo'. Perhaps you are missing $string['modulename'] = ''; in mod/turnitintooltwo/lang/en/turnitintooltwo.php?
line 356 of /lib/classes/string_manager_standard.php: call to debugging()
line 7012 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 137 of /blocks/sharing_cart/lib/settingslib.php: call to get_string()
line 60 of /blocks/sharing_cart/settings.php: call to admin_setting_configmulticheckboxmodtypes->__construct()
line 128 of /lib/classes/plugininfo/block.php: call to include()
line 81 of /admin/settings/plugins.php: call to core\plugininfo\block->load_settings()
line 8857 of /lib/adminlib.php: call to require()
line 9017 of /lib/adminlib.php: call to admin_get_root()
line 26 of /admin/upgradesettings.php: call to admin_write_settings()
Callback before_standard_html_head in report_allylti component should be migrated to new hook callback for core\hook\output\before_standard_head_html_generation
line 7459 of /lib/moodlelib.php: call to debugging()
line 7523 of /lib/moodlelib.php: call to {closure}()
frederikmillingpytlick commented 2 months ago

That's an issue with the plugin you've linked to, not sharing cart.

The "modulename" string is requrired for all mod_xxx plugins :)

Closing issue...