search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 35 forks source link

Copy content issue on Moodle 4.4 #203

Open RayCoSector opened 2 weeks ago

RayCoSector commented 2 weeks ago

Hello,

We've noticed that the latest release has issues in Moodle 4.4 when you try and copy shared content back into another course when using 4.4, release 3 (2024020501)

On Copying content: image

Item appears in Sharing Cart: image

Navigate to another course & Click copy to course. The top menu appears, but there is no dotted box to indicate where the item should be copied to: image

Does anyone know a fix for this ? Will this be fixed when version 4.5 lands - any updated news on when this might be ?

Regards, Ray Reid.

aspark21 commented 1 week ago

@donhinkelman i can get one of our devs to look at this in the coming week but would it be worth them looking at basing this on your dev branch?

RayCoSector commented 5 days ago

We've had this fixed for one of our customers and they would like to share with the community.

https://github.com/donhinkelman/moodle-block_sharing_cart/pull/204

Regards, Ray Reid.

leonstr commented 3 days ago

It looks like this is a result of MDL-74778 which removed course formats' format.js files which described each format's section containers. Replacing M.course.format.get_section_wrapper() -- broken by MDL-74778 -- with 'li.section' resolves the issue but hopefully there's a dynamic way to obtain this as hard coding this value may not work with all supported course formats, or future changes to course formats.