The copy of a section from one course to another one doesn't work properly.

[JoseFSala]

Some of the assignments and folders of the original section do not match their copy in another course, as shown in the image.

Moodle 3.8.2+ (Build: 20200312)

Sharing Cart block_sharing_cart

3.8, release 1 2020031500

[donhinkelman]

Thank you, Josef. The two sections are clearly and significantly different. I will attempt to reproduce this issue.

[JoseFSala]

Hi Don. This issue was hapenning to me in the previous Moodle version, 3.6.7+, as well. I used to copy each activity individually instead of a section to avoid this error. Even though it was a time consuming task, this way I was sure the copy was correctly made.

[donhinkelman]

Hi Josef, it sounds like this problem might have been from the original addition of this feature. Did the issue happen the first time you used section copy? Did section copy ever work well for you? When was approximately the first time you remember using section copy?

[donhinkelman]

[donhinkelman]

The first screenshot shows the original section items. The second screenshot shows the items after copying to another course. Two items have disappeared in the transfer, and two items were duplicated in their place (marked in red). This confirms the issue remains in Moodle 3.8, SC 3.8, release 2. Browser is Firefox.

[JoseFSala]

Hi Don, My answers to your questions.

Did the issue happen the first time you used section copy? Yes.

Did section copy ever work well for you? No.

When was approximately the first time you remember using section copy? October 2019.

Thanks, José Francisco Sala

[JoseFSala]

I am uploading heavy video files, some of them close to 1 GB. Now Sharing Cart block is not working, and I cannot see the way of copy a single activity. This is a big problem for me. José

[JoseFSala]

Don, I have uninstalled and reinstalled the sharing cart block, and the same error window shows up. José

[donhinkelman]

Hi Josef, The section copy problem (some items not copied or duplicated) is probably different from the problem you are describing now. I have asked a programmer to look at the section copy problem. Now this other problem with the video files may be different--I don't understand the error message above. But you are trying to move 1gb files with the Sharing Cart. This will cause problems even if you use Backup/Restore because of various reasons. Your upload settings in the server may be too low. Moodle settings for upload may too low. Please check these. If you can use the Sharing Cart for smaller files, then that may be the answer. Now I assume you have installed Sharing Cart 3.8, release 2 (which was put on Moodle.org plugins two days ago). Another suggestion is that you avoid putting video files on your Moodle courses, but instead upload them to Youtube, and paste the links on your Moodle course. This practice will help in many ways.

[JoseFSala]

Hi Don, Yes, I have installed Sharing Cart 3.8, release 2 (2020032600).

The Moodle settings for uploading files are the server limit (site upload limit: 1 GB).

I have increased the Extra PHP memory limit from 512 MB to 4096 MB.

I have bulk deleted all files in the Sharing Cart block and tried to copy section «6. Ecuaciones» again, but the same undefined error showed up:

undefined - Error

405 Not Allowed

---

nginx/1.16.1

I thank you your suggestion of avoiding to put video files on my Moodle courses, and instead uploading them to YouTube. Most of the video files should be kept private. As far as I know, there is an option to keep videos private in YouTube, but I'd prefer put them in my Moodle site, because I think it is a safer environment. In the meanwhile, I would like to help solving those Moodle errors.

By the way, my first name is not Josef. It is a compound name, José Francisco. This is the reason of using the GitHub handle «JoseFSala» (the same as my Twitter handle @JoseFSala), since my first last name is Sala. Instead of using the compound first name José Francisco, it might be used only José (Joseph in English).

Regards, José Sala

[JoseFSala]

Hi Don,

I have taken some screenshots as a complementary information for the error shown when there are heavy video files.

Regards, José Sala

[donhinkelman]

Thank you Jose, I really appreciate all the screenshots, particularly the error message. I asked a programmer about it and he replied:

"The error code is "405 Method not allowed". This does not seem to be Moodle error, but the server (nginx) error. It would help with more detail by opening inspector mode of the browser, and monitor the network when error is occurred, if they can provide me the URL, method, header (and body content if any) of the request which provides this 405 error."

Since it is not a Moodle error, I will suggest you to examine your browser, URL, method, header, etc. Also since you reported that the video were sometimes over 1gb, I wonder if your server settings (such as php.ini) were causing this issue.

[ponlawat-w]

Dear @donhinkelman and @JoseFSala, After investigating the issue, the problem is caused by backing up modules which have identical names or mutual prefix in their names, at the same time. Because previously, sharing cart stores the module with file name dervied from module name and back up time, which leads to duplication in case of module names are alike and backing them up at the same time (copy section). The problem is fixed in pull request #41 by adding module ID into file name to create uniqueness.

The picture below is from my test site, it now restores all the modules correctly:

[donhinkelman]

That is great to hear you could find and solve the problem. I will check it out later. Don

On Apr 11, 2020, at 12:54, Ponlawat WEERAPANPISIT notifications@github.com wrote:

Dear @donhinkelman https://github.com/donhinkelman and @JoseFSala https://github.com/JoseFSala, After investigating the issue, the problem is caused by backing up modules which have identical names or mutual prefix in their names, at the same time. Because previously, sharing cart stores the module with file name dervied from module name and back up time, which leads to duplication in case of module names are alike and backing them up at the same time (copy section). The problem is fixed in pull request #41 https://github.com/donhinkelman/moodle-block_sharing_cart/pull/41 by adding module ID into file name to create uniqueness.

The picture below is from my test site, it now restores all the modules correctly:

https://user-images.githubusercontent.com/15243484/79034684-52312800-7be2-11ea-9f9b-ebed8a2542c6.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/donhinkelman/moodle-block_sharing_cart/issues/40#issuecomment-612317306, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCQQRVUHW225LSQLDB533TRL7SV5ANCNFSM4LPX3HCA.

[JoseFSala]

I understand this issue will be fixed in the next Sharing Cart release, isn’t it?

Thanks so much, José Sala

On 11 Apr 2020, at 07:46, Don Hinkelman notifications@github.com wrote:

That is great to hear you could find and solve the problem. I will check it out later. Don

On Apr 11, 2020, at 12:54, Ponlawat WEERAPANPISIT notifications@github.com wrote:

Dear @donhinkelman https://github.com/donhinkelman and @JoseFSala https://github.com/JoseFSala, After investigating the issue, the problem is caused by backing up modules which have identical names or mutual prefix in their names, at the same time. Because previously, sharing cart stores the module with file name dervied from module name and back up time, which leads to duplication in case of module names are alike and backing them up at the same time (copy section). The problem is fixed in pull request #41 https://github.com/donhinkelman/moodle-block_sharing_cart/pull/41 by adding module ID into file name to create uniqueness.

The picture below is from my test site, it now restores all the modules correctly:

https://user-images.githubusercontent.com/15243484/79034684-52312800-7be2-11ea-9f9b-ebed8a2542c6.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/donhinkelman/moodle-block_sharing_cart/issues/40#issuecomment-612317306, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCQQRVUHW225LSQLDB533TRL7SV5ANCNFSM4LPX3HCA.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/donhinkelman/moodle-block_sharing_cart/issues/40#issuecomment-612336122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN5I4KG2PAYEVIFVLHFURZ3RL774DANCNFSM4LPX3HCA.

[donhinkelman]

Hi Jose, this fix was merged into today's new release, Sharing Cart 3.8, release 3. Thanks to Ponlawat Weerapanpisit, graduate student of engineering at Chiang Mai University, and programmer of the section copy feature. I have tested this fix and will close this issue.