donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

"copy to sharing cart" option completely dissappears with Grid courseformat #48

Closed Urpokarhu1 closed 4 years ago

Urpokarhu1 commented 4 years ago

Sharing cart dissappears from settings-menu when you delete general section that has been moved in to the Grid in Grid-courseformat. See attached video.

sharingbug.zip

Steps to repeat:

  1. Create a new course in Grid format with default settings
  2. In the General section click "move section into grid"
  3. Check that General-section edit menu has "copy to sharing cart" (for some reason it has two menuitems there)
  4. Delete General-section
  5. Check that general section has "copy to sharing cart"
  6. Refresh the webpage
  7. Notice that General section or any other section doesn't have anymore "copy to sharing cart" option available and you cannot restore them.

tested with Moodle 3.5 & format_grid 3.5.0.6 (2018052306) & block_sharing_cart 3.3, release 3 (2018012400)

donhinkelman commented 4 years ago

Thanks, Urpokarhu. I really appreciate the methodical notes you sent to show the problem and the clear screencast video you sent. That's the good news. The bad news is I am not a programmer and the volunteer programmers who work on the Sharing Cart only have time for standard themes and standard course formats. We have also upgraded Sharing Cart to 3.8.10 and wish you could upgrade your Moodle to take advantage of the new layout and all the bug fixes that went into it. I wonder if anyone else using the Grid format has had better SC performance in Moodle 3.8?

Urpokarhu1 commented 4 years ago

Hello,

Sharing cart has changed in version 3.8 completetly and it works with Grid course format because section copy have been moved from under edit menu to the block itself.

donhinkelman commented 4 years ago

Well, that is wonderful news, Urpokarhu. I hope you can use Sharing Cart 3.8 on your Moodle 3.5 site.

donhinkelman commented 4 years ago

I am closing this issue. Thanks for reporting the original problem and how it was solved.