search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

Avoid misunderstanding of the "Copy to sharing cart" icon as inactive #68

Closed abias closed 1 year ago

abias commented 4 years ago

Hi Don, dear Praxis team,

while upgrading to Moodle 3.9 and Sharing Cart 3.8 Release 10, I saw that you have pulled the "Copy to sharing cart" functionality out from the activity edit menu and have changed it to a dedicated icon:

image

While I appreciate this change, I am afraid that the fact that you are showing the icon with a very light tone of the brand color and are changing it to a solid color only while hovering can produce misunderstandings for users who think that the icon is disabled. And, because of the low contract, it can trigger accessibility problems as well, of course.

I would like to ask you to rethink this choice and use a more solid color when not hovered. Ideally, use the group icons of Moodle core as example:

image

They have a solid color when not hovered, but they also have a small hovering effect.

Thanks for your consideration.

Cheers, Alex

Kathrin84 commented 4 years ago

He there,

Alex asked me to add my insights.

The reason for this appearance is this rule:

.add-to-sharing-cart {
    opacity: 0.3;
}

https://github.com/donhinkelman/moodle-block_sharing_cart/blob/2aef67b212c48bc13caa5df6e313899f4ba1a660/styles.css#L127-L129

In our individual theme RAW SCSS, we changed this back to full opacity. Even with full opacity, there is still a hovering effect.

Best, Kathrin

abias commented 3 years ago

I would like to point out that this problem still persists in Version 3.9, release 3. But I think that it should be easy to fix.

AraPraxis commented 1 year ago

CSS, styling and functionality has been updated in Moodle 4.0+ releases.

We do not intent to make any updates to sharing cart prior to Moodle 4.0 - However we do follow the Moodle releases and are willing to fix any security risks regarding this plugin. https://moodledev.io/general/releases

Kind regards, Anders Rasmussen

Praxis Team