search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

Improve look of "Copying this shared item" notification #69

Closed abias closed 1 year ago

abias commented 4 years ago

Hi Don, dear Praxis team,

while upgrading to Moodle 3.9 and Sharing Cart 3.8 Release 10, I had a look at the nice look & feel improvements which have been realized by you, but I also saw that the "Copying this shared item" notification is fully unstyled and thus quite ugly:

image

On https://github.com/donhinkelman/moodle-block_sharing_cart/blob/master/styles.css#L93-L99, there would be styles to style this notification with a dashed border similar to the drop zone, but maybe the .clipboard element got moved out of the .course-content element in some previous commit so that the selector does not apply anymore?

Against this background, I would like to ask you to have a look at this unstyled notification and, at least, fix the CSS selectors so that they apply again but, even better, change the notification into a nicely looking notification which matches Moodle core's look & feel.

Thanks in advance!

Cheers, Alex

abias commented 3 years ago

I would like to point out that this problem still persists in Version 3.9, release 3. But I think that it should be easy to fix.

donhinkelman commented 3 years ago

Good suggestion and I hope Praxis will have time for these many minor fixes. Soon I will be making a 3.10 release, but this problem will still persist.

frederikmillingpytlick commented 1 year ago

Closing issue, this has been implemented billede