Course module backup menu item isn't added properly - Githubissues

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.

7 stars 38 forks source link

Course module backup menu item isn't added properly #8

Closed johnnypraxis closed 5 years ago

johnnypraxis commented 5 years ago

Sometimes the value of the "data-action" attribute isn't changed to "backup" when the first menu element is cloned and called "Copy to Sharing Cart".

This means the backup action doesn't work as expected. Both the dublicate and the backup action is called when the new cloned menu item (Copy to Sharing Cart) is clicked and that results in a "nopermission" popup. See screenshot:

Unfortunately I can't say exactly how to reproduce this bug but this pull request fixes the bug: https://github.com/donhinkelman/moodle-block_sharing_cart/pull/7

donhinkelman commented 5 years ago

This issue has been merged into the master, and now closed. Thank you, JohnnyPraxis!