search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

5x Sharing Cart -- Course not usable any more #86

Closed white-rabbit07 closed 1 year ago

white-rabbit07 commented 3 years ago

Hi. I wanted to add a Sharing Cart to my course ... and it took a while until the block appeared. Obviously I clicked on "Add block ..." some more times. Now the course is not usable any more. I get this:

sharing_cart The webpage can't load any more ... what's wrong there or how to solve it? Thanks.

donhinkelman commented 3 years ago

Thank you for reporting a problem. In order to fix an issue, we need to reproduce it. So please tell me your Moodle version number, the Sharing cart version number, the browser you are using, the Moodle theme you are using and the any other modifications to your site that may be related. Usually the problem is the theme, because the Sharing Cart works with standard themes.

white-rabbit07 commented 3 years ago

Hi. We use Moodle 3.8.6 (Build: 20201109) with Sharing Cartblock 3.8, release 172020090100 Browser: Any -- tested with FF, Chrome, Opera Modifications: none -- Theme: Boost (default) I think the problem was that I clicked on "sharing cart" several times ... so it was added many times to the course!? The course can't be used any more as soon as I switch to editing mode (the sharing cart appears many times on the right then...)

hope this helps? Greetings.

donhinkelman commented 3 years ago

Thanks for reporting all the helpful details and sorry for my late reply. Could you tell me if this problem is still an issue after upgrading to Sharing Cart 3.9, release 3?

donhinkelman commented 3 years ago

Hi Johnny, I am wondering if this issue is urgent. What do you think? Can you work on it or close it if it has been fixed. Also, if you think it is timely, I would like to announce Sharing Cart 3.10 on the moodle.org plugins database and begin testing it on Moodle 3.11.

white-rabbit07 commented 3 years ago

Hi. As our moodle runs in a school I just updated Sharing Cart without forcing the potential bug again .... so I can't tell you if the problem still exists. Last time the course was unusable afterwards ... that's too critical at the moment.

donhinkelman commented 3 years ago

I see. Thanks for trying. I see your problem.

johnnypraxis commented 3 years ago

Hi Don I haven't had time to test the issue. However it doesn't seem like a critical issue but it's something we need to test. Therefore I'll leave this issue open until one of my team members has the time to look into it. I will create a Moodle 3.10 branch today and push the files :-)

donhinkelman commented 2 years ago

Hi Johnny, any information on testing of this one?

johnnypraxis commented 2 years ago

Hi Don No not yet. We got a lot of tasks at the moment and not enough hands. Feel free to test the issue.

AraPraxis commented 1 year ago

I've personally tried to spam the "sharing cart" button when adding a new instance to a course and it seems that the course has a hard time loading multiple sharing carts.

I'll look further into fixing this, if possible, as Moodle also have a special way of handling added instances.. I'll look into it and try and update Moodle 4.0+ as we will not update the sharing cart prior to Moodle 4.0 - However we do follow the Moodle releases and are willing to fix any security risks regarding this plugin. https://moodledev.io/general/releases

image

Kind regards, Anders Rasmussen

Praxis Team

AraPraxis commented 1 year ago

I've looked further into this, and when it comes to Blocks in Moodle, they don't really give an optimized way of preventing this - The only way would be to delete the duplicated instances if you click more than once, but that's not be the best way to prevent this.

I've tried to describe the problem to Moodle as it's not only the sharing cart but any block that should not be added more than once to a course. Moodle Tracker issue: https://tracker.moodle.org/browse/MDL-77710

I would like to address that the way the course breaks, for me too, is rather odd but we will hopefully have time in the future to make the sharing cart run more smoothly!

I see that we close the issue, since it's Moodle that needs their source code updated :)