search

donhinkelman / moodle-block_sharing_cart

Content sharing plug-in for Moodle LMS. Now at version 4.4, release 3 (actually this is for Moodle LMS version 4.3. Requires PHP 7.4.
7 stars 38 forks source link

Missing string in AMOS #92

Closed dinism closed 1 year ago

dinism commented 3 years ago

I'm a PT-PT tanslator and i didn't find this string in AMOS: $string['label_image_replaced_text'] = ' (Label: Image)'; imagem

mcardle commented 3 years ago

Have you tried looking under mod_label - I think the string in the original one from mod_label. You can test this by inserting another type of activity and see if the string changes.

dinism commented 3 years ago

In file .../lang/en/block_sharing_cart.php are 64 strings and in AMOS are 59 (5 missing).

I compared and i found what is missing. imagem

https://github.com/donhinkelman/moodle-block_sharing_cart/commit/b0c9a85fb9317e6e0959da374a144ecb4ee1496b#diff-7613af6cca62064701d464e79d3afadab9db561a54193ec450db99d8a68abef4

https://github.com/donhinkelman/moodle-block_sharing_cart/commit/8538d52a3d19b7aa399534779c896d7f4f06f918#diff-7613af6cca62064701d464e79d3afadab9db561a54193ec450db99d8a68abef4

donhinkelman commented 3 years ago

Thank you dinism for reporting this issue #92. I assume you are using Sharing Cart 3.9 release 3. Macardle, are you able to work on this or shall I assign Johnny Drud to this issue?

dinism commented 3 years ago

Thanks for reply. I'm using Sharing Cart 3.9 release 3.

AraPraxis commented 1 year ago

Since no updates have been emitted, we see the issue as closed.

If the problem still occurs on Moodle 4.0+ then you're welcome to create a new issue regarding the error, but we will not update the sharing cart prior to Moodle 4.0 - However we do follow the Moodle releases and are willing to fix any security risks regarding this plugin. https://moodledev.io/general/releases

Kind regards, Anders Rasmussen

Praxis Team