search

doniform / koosli.org

MIT License
0 stars 0 forks source link

Migrate #38

Closed fumbleforce closed 9 years ago

fumbleforce commented 10 years ago

Migrate all the things. UserQuery model, with no connection to a user Admin page to get counts for users and queries.

fumbleforce commented 9 years ago

Well that rebase didn't quite go as planned. Most of it is back where it belongs though, but the migrations are not playing nice with some of the tests, not all tables are being created.

After moving some search related functionality to the search package, it clashed with your additions to the providers.

thusoy commented 9 years ago

Only thing missing now is migrating the query table, which isn't done right now as far as I can tell. If you can add migrations for that as well (we need one for the current state, which is what's here, so that we can tell alembic that this is the current version), we're good to go. Don't merge yet, I suspect I need to be present to prevent failure since it's the first alembic run, needs a little manual intervention to tag the database before it'll work.

fumbleforce commented 9 years ago

migrations/versions/2808584031e9_query_model.py`, close to the bottom of the files changed

This was not done correctly? Something missing?

thusoy commented 9 years ago

Only thing missing seems to be an easy way to see files added in the GitHub web interface, I couldn't find that file last time I looked. Jeez.

If you rebase to keep the git log a bit more readable this is all :+1: to me.