donmccurdy / KTX-Parse

KTX 2.0 (.ktx2) parser and serializer.
MIT License
48 stars 7 forks source link

Fix error with uint8array values in kv data #81

Closed gz65555 closed 1 year ago

gz65555 commented 1 year ago

Fix #78

According to the KTX spec:

I modified the write method. If it's a uint8array, I didn't write a termination character. And also modified the read method. If it's parsed as a string, I replaced the termination character (if any) using regex.

codecov-commenter commented 1 year ago

Codecov Report

Merging #81 (2a6b5c0) into main (ffc037f) will increase coverage by 0.11%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   97.52%   97.64%   +0.11%     
==========================================
  Files           7        7              
  Lines         971      977       +6     
  Branches       38       38              
==========================================
+ Hits          947      954       +7     
+ Misses         24       23       -1     
Impacted Files Coverage Δ
src/buffer-reader.ts 94.20% <100.00%> (+0.55%) :arrow_up:
src/read.ts 98.61% <100.00%> (+<0.01%) :arrow_up:
src/write.ts 94.57% <100.00%> (+0.42%) :arrow_up:
donmccurdy commented 1 year ago

Thank you @gz65555! Published.