search

donmccurdy / glTF-Transform

glTF 2.0 SDK for JavaScript and TypeScript, on Web and Node.js.
https://gltf-transform.dev
MIT License
1.43k stars 150 forks source link

Error message formating #1146

Closed Makio64 closed 1 year ago

Makio64 commented 1 year ago

Describe the bug The formating of the message error seems broken weld: Requires 0 Γëñ tolerance Γëñ 0.1

To Reproduce give a wrong "weld"

Expected behavior correct formating for Γëñ

Versions:

donmccurdy commented 1 year ago

I guess this may depend on your terminal and/or font – the characters are ≤ symbols.

If you'd like to make a PR it would be welcome!

https://github.com/donmccurdy/glTF-Transform/blob/fad253d2925056f62b828137d5148d6a11c72e39/packages/functions/src/weld.ts#L418-L424

Makio64 commented 1 year ago

@donmccurdy Sure, replacing by <= instead of the special character would be ok for you ?

donmccurdy commented 1 year ago

That works for me, yes!

donmccurdy commented 1 year ago

Fixed by https://github.com/donmccurdy/glTF-Transform/pull/1155.