Added failing test for join and prevent pruning of empty nodes with custom data

donmccurdy / glTF-Transform

glTF 2.0 SDK for JavaScript and TypeScript, on Web and Node.js.

https://gltf-transform.dev

MIT License

1.3k stars 145 forks source link

Added failing test for join and prevent pruning of empty nodes with custom data #1281

Closed Archimagus closed 4 months ago

Archimagus commented 4 months ago

test for: #1278 This pull request adds a failing test for the join function which shows it pruning nodes that have "extra" data that shouldn't be removed, at least optionally.

donmccurdy commented 4 months ago

Had to make some additions here, but this is continued in https://github.com/donmccurdy/glTF-Transform/pull/1302 — thank you!