donmccurdy / three-gltf-viewer

Drag-and-drop preview for glTF 2.0 models in WebGL using three.js.
https://gltf-viewer.donmccurdy.com/
MIT License
2.13k stars 537 forks source link

fix active camera aspect ratio #226

Closed dkrnl closed 3 years ago

dkrnl commented 3 years ago

Hi!

Custom camera(camera from gltf-file) not resized.

Thx!

donmccurdy commented 3 years ago

Hi! There seem to be a lot of other changes in this PR, did you mean to include all of them?

I'm not sure if this resizing is something the viewer should do automatically. If an orthographic camera in the file specifies its own height/width, I don't know if the viewer should override that to match the user's browser.