search

donmccurdy / three-gltf-viewer

Drag-and-drop preview for glTF 2.0 models in WebGL using three.js.
https://gltf-viewer.donmccurdy.com/
MIT License
2.13k stars 537 forks source link

Parcel 1.12.4 breaks three-gltf-viewer #246

Closed canadaduane closed 3 years ago

canadaduane commented 3 years ago

FYI: I was unable to get three-gltf-viewer running "off the shelf" due to this bug:

https://github.com/parcel-bundler/parcel/issues/5943

Here's the output I saw:

yarn run v1.23.0-0
$ parcel index.html --port 3000
Server running at http://localhost:3000
🚨  /Users/duane/Relm/three-gltf-viewer/assets/favicon.ico: Invalid Version: undefined
    at new SemVer (/Users/duane/Relm/three-gltf-viewer/node_modules/semver/semver.js:314:11)
    at compare (/Users/duane/Relm/three-gltf-viewer/node_modules/semver/semver.js:647:10)
    at lt (/Users/duane/Relm/three-gltf-viewer/node_modules/semver/semver.js:688:10)
    at /Users/duane/Relm/three-gltf-viewer/node_modules/@babel/preset-env/lib/index.js:280:22
    at Object.default (/Users/duane/Relm/three-gltf-viewer/node_modules/@babel/helper-plugin-utils/lib/index.js:22:12)
    at getEnvPlugins (/Users/duane/Relm/three-gltf-viewer/node_modules/parcel-bundler/src/transforms/babel/env.js:62:34)
    at getEnvConfig (/Users/duane/Relm/three-gltf-viewer/node_modules/parcel-bundler/src/transforms/babel/env.js:12:25)
    at async getBabelConfig (/Users/duane/Relm/three-gltf-viewer/node_modules/parcel-bundler/src/transforms/babel/config.js:32:19)
    at async babelTransform (/Users/duane/Relm/three-gltf-viewer/node_modules/parcel-bundler/src/transforms/babel/transform.js:6:16)
    at async JSAsset.pretransform (/Users/duane/Relm/three-gltf-viewer/node_modules/parcel-bundler/src/assets/JSAsset.js:83:5)
donmccurdy commented 3 years ago

It looks like the upstream bug is fixed and all dependencies are up to date here. 👍