donn / nudelta

Open source NuPhy Console alternative
GNU General Public License v3.0
521 stars 24 forks source link

Halo75 - remap is written but not applied nor saved #19

Closed pngo closed 1 year ago

pngo commented 1 year ago

Remaps are said to be written image

Typing in Notepad, the mapping is not applied.

Closing nudelta, opening nudelta again, and reloading keyboard, the default keymap is shown. (proving the keymap has not been written)

Nudelta version : 0.6.3 OS: Win 10 Keyboard: Halo75 Firmware: 0102

donn commented 1 year ago

Nudelta does not read the incoming keymap from your keyboard, so reloading it will always show the default keymap.

Out of curiosity- can you try switching your keyboard to Mac mode and seeing if it remapped that one?

pngo commented 1 year ago

Switched to Mac mode, and the keymap works. So yes it was writing the keymap to the Mac Mode, even though it detected Windows correctly at start up of nudelta (refer back to screenshot in first post)

Checked the other way around, Nudelta Mac Mode, and write the changes. The keymap is applied to Windows Mode on Keyboard.

Conclusion: the mode selection vs writing is flipped. Nudelta mode MAC writes to WIN keymap Nudelta mode WIN writes to MAC keymap

nocturne1 commented 1 year ago

Can confirm this behavior. We're almost there!

donn commented 1 year ago

…I'm confused now. I flipped it in the first place because @nocturne1 reported this same behavior on 0.6.2.

Can you both try 0.6.2? Literally the only change from 0.6.3 is that the Mac and Windows mode are swapped around. That's it: https://github.com/donn/nudelta/releases/tag/0.6.2

pngo commented 1 year ago

With 0.6.2, I have the following

Are people getting confused with the M and W switch, depending on how they look on their keyboard, and thus expecting wrong OS keys? I check the orientation of the other icons, from left to right it would be : W M ------ OFF, Wired, Wireless ----- USB plug

nocturne1 commented 1 year ago

No confusion here with the physical switch.

0.6.2 messed up my mapping so much, I had to use Windows boot camp to re-flash the firmware (or I guess I could have used Windows mode, but I did't want to do that).

pngo commented 1 year ago

Difference in Windows / Mac builds then ?

donn commented 1 year ago

The builds are identical.

From what I'm seeing here- it appears that reverting the codebase to the state of 0.6.2 but also switching the YAML files around is probably the right approach. I'll try that when I have some time.

Weathercold commented 1 year ago

So the problem was that the yaml files are reversed? I tried to inform you about this a week ago but I think you didn't see it 😅 https://github.com/donn/nudelta/commit/99c38728427f1031544d0673e4b764213535ed2f#r94643080

donn commented 1 year ago

@Weathercold You're right!! I didn't! I scrolled all the way down, didn't see anything and I was like "weird, is it a glitched notification?"

Thanks for the alert, this is simpler than I expected lol

donn commented 1 year ago

Try 0.6.4. Sorry this is taking so long…

pngo commented 1 year ago

Can confirm it works now as expected! Thank you and ill be happy to test in future as well.

nocturne1 commented 1 year ago

Can also confirm this fixed things. Thanks @donn !