search

donnell74 / CSC-450-Scheduler

MIT License
1 stars 1 forks source link

Adds timeboxing logic and gui components #21

Closed hana9235 closed 10 years ago

prichey commented 10 years ago

This is just semantics but maybe it should be Quick (~1 Minute) or Quick (<1 minute) or something like that?

When I ran the quick route it was definitely less than one minute so in my opinion maybe we should reflect that it will be 1 minute-ish?

donnell74 commented 10 years ago

It might be a bad idea to do that. And it is still quitting when it finds five valid schedules so you have to set a few constraints to hit the full time limit.

On Nov 6, 2014 10:36 PM, Preston Richey notifications@github.com wrote:

This is just semantics but maybe it should be Quick (~1 Minute) or Quick (<1 minute) or something like that?

When I ran the quick route it was definitely less than one minute so in my opinion maybe we should reflect that it will be 1 minute-ish?

Other than that looks great, good work!

Reply to this email directly or view it on GitHubhttps://github.com/donnell74/CSC-450-Scheduler/pull/21#issuecomment-62094739.

prichey commented 10 years ago

If you don't like that suggestion could you at least give a reason why?

Also why is this merging straight to master?

donnell74 commented 10 years ago

Sorry it should of read it might not be a bad idea to do that, emailing from my phone. I think that is a good idea because we can not stop right at a minute because it only checks to stop it at the end of each iteration. And it is not merging to master because we merge to develop. Keep testing it and then when we have our meeting before sprint demo we move into master so that way master is always releasable code. This also helps keeps code from being pushed to production that has bugs in it.

On Nov 6, 2014 11:05 PM, Preston Richey notifications@github.com wrote:

If you don't like that suggestion could you at least give a reason why?

Also why is this merging straight to master?

Reply to this email directly or view it on GitHubhttps://github.com/donnell74/CSC-450-Scheduler/pull/21#issuecomment-62096271.

prichey commented 10 years ago

Okay, that makes sense.

Yeah, I totally agree that we should only be pushing to master with tested / releasable. I just was wondering because this pull request is wanting to merge timeboxed to master.

CameronHKIng commented 10 years ago

Most likely because it's the default.

hana9235 commented 10 years ago

The merge directly to master thing is my fault; I was just about to head to bed and didn't read it properly. Sorry. I've changed the times, like you guys suggested.