search

donnell74 / CSC-450-Scheduler

MIT License
1 stars 1 forks source link

Room availability #73

Closed feq574 closed 9 years ago

feq574 commented 9 years ago

New constraint for room availability Gui support for room availability Tests made for room availability

donnell74 commented 9 years ago

I worked on this with Felix and it looks good to me

hana9235 commented 9 years ago

Looks good. Since this is the only room constraint we're going to have time for (as far as I know) I don't think we need that "type" dropdown menu. It's confusing to have two dropdowns that both say "available." That, or changing the Type dropdown to "availability" would be more clear. Otherwise, looks good to me, nice job!

prichey commented 9 years ago

I agree with Hana, there should only be one dropdown for 'Available' / 'Not Available'. Other than that nice work!

donnell74 commented 9 years ago

Thanks, took opition one. The second one seemed like it would be a lot more work

CameronHKIng commented 9 years ago

Deleting a room availability constraint in the constraints added box should remove the relevant entry in self.rooms_avail (also, this should be handled in delete all as well). Currently, it does not do so; there is no way to take out a room availability entry other than to restart the program.

There also is no logic in interface.py to add room timeboxing from the default constraints YAML file. That's probably okay though.

CameronHKIng commented 9 years ago

What is the point of adding availability? Is the effective availability of a room the difference between times available and not available (so if you set all day to not available, then 8:00-8:50 as available, this is the only timeslot that is available)?

donnell74 commented 9 years ago

First comment: We will fix the deletes. The interface logic might get done, depends on time though. Second comment Adding availability is saying that it is only available during a certain time, otherwise it is available at all times. Reverse logic for availability is not available like how you explained, but can be added relatively easily.

CameronHKIng commented 9 years ago

Okay, great. Let me know if you need any help.

I would be careful with the reverse logic deal; what would happen if the input was "Avail 8:00-8:50" and "Not Avail 8:00-8:50"?

donnell74 commented 9 years ago

Good point, the reverse logic is not possible and also not logical to do it that way.

feq574 commented 9 years ago

Good to go