Reactive python 3.6 in gitsome

[szlin]

This PR is trying to fix #105 and reactive python 3.6 in gitsome.

Since xonsh has fixed the issue in python 3.6, the gitsome should work fine with python 3.6. I had some tests done on my side, please review on it.

Thanks.

[codecov-io]

Codecov Report

Merging #135 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files          36       36           
  Lines        2817     2817           
=======================================
  Hits         2232     2232           
  Misses        585      585

[donnemartin]

Hi @szlin, I recall there were issues running in Python 3.6 because gitsome has a bundled version of xonsh, instead of listing it as a dependency. I'm not seeing a change in this PR that addresses that?

[szlin]

@donnemartin Do you mind to remove embedded code copies and add dependency with xonsh? I am the gitsome package maintainer in Debian, and the copies of code need to be removed in Debian archive according to Debian policy 4.13, hence I had created a patch for removing xonsh - Removal xonsh patch in Debian

[donnemartin]

This is something I'm hoping to get fixed at some point with https://github.com/donnemartin/gitsome/issues/25, I recall at the time there were issues trying to unbundle xonsh.

It sounds like you've already done this, did you face any issues?

[szlin]

@donnemartin I haven't seen any issues and received any bug reports so far since 2017-02-20. You may reference to following link: gitsome in Debian

[dbaio]

+1

It would be nice to unbundle xonsh and have a new release of gitsome as well.

Regards.

[ryukinix]

Looking for that getting fixed/merged for months! Great job guys :) Congrats. Waiting happily ~

[ryukinix]

Any news?

[donnemartin]

Hi everyone, I'm seeing issues with this, see https://github.com/donnemartin/gitsome/issues/105.

[szlin]

@donnemartin Sorry, I still don't get the point. The issue of #105 seems to be closed since upstream of xonsh had merged the patches.

The gitsome with my patches works fine for me, and got no bug report both in Debian [1] and Ubuntu [2] over past 10 months.

Could anyone provide the reproducible steps for python3.6 error in gitsome after applying my patches? I can have a look afterwards.

szlin@szlin-TW:/home/szlin/gitsome# python3 setup.py egg_info
running egg_info
creating gitsome.egg-info
writing gitsome.egg-info/PKG-INFO
writing dependency_links to gitsome.egg-info/dependency_links.txt
writing entry points to gitsome.egg-info/entry_points.txt
writing requirements to gitsome.egg-info/requires.txt
writing top-level names to gitsome.egg-info/top_level.txt
writing manifest file 'gitsome.egg-info/SOURCES.txt'
reading manifest file 'gitsome.egg-info/SOURCES.txt'
writing manifest file 'gitsome.egg-info/SOURCES.txt'
szlin@szlin-TW:/home/szlin/gitsome# python3 --version
Python 3.6.6+

[1] https://tracker.debian.org/pkg/gitsome [2] https://launchpad.net/ubuntu/+source/gitsome

[iamareebjamal]

1.5 years since last release and a lot of people want 3.6 support. Contributors have sent a pull request. I request @donnemartin to please have a look, approve and merge it. If you see a problem with it, please convey it so that one the OP or someone else may address it. I understand that you might be busy with other things in your life, hence, you may think of adding some other maintainers on the project so it takes the load off your head, maybe?

People love this awesome tool but it is not moving forward

[donnemartin]

Hey all, sorry been really busy. I'm starting to free up and plan to look into updating gitsome to support the latest Python versions.

[donnemartin]

Fixed with https://github.com/donnemartin/gitsome/pull/160, gitsome now support Python 3.7.